BUG: 408170
Fix most layer properties windows and change clone source window drawing on top of other application windows.
Was using Qt::WindowStaysOnTopHint window flag, removed and set modal instead.
Details
Details
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Hm... I'm not sure about the way forward here. The reason these dialogs were not model was to allow the user to pan and zoom the image while working on the properties of a layer:
commit 1272564eeeabf2e2a8d1cbd6315f32c48a4fc7a1
Author: Eoin O'Neill <eoinoneill1991@gmail.com>, Tue Jan 22 16:06:42 2019 -0800 (4 months ago)
Committer: Eoin O'Neill <eoinoneill1991@gmail.com>, Tue Jan 29 13:50:03 2019 -0800 (4 months ago)
Follows: v4.2.0-prealpha
Precedes: 4.2.0-pre-alpha-HDR
Branches: <Expand>
Changed The Properties for Generator (Fill) Layers to be Non-Modal
This change moves toward consistency with other properties windows
allowing you to move the properties window of a fill layer. The new window
can be called either as modal or non modal depending on whether or not it has
existing layer data passed into it. This means that creating a new fill layer
uses a modal window while editing allows you to move the window to the side to compare
and contrast values.
Comment Actions
In that case could probably use the Qt::Tool window flag instead of Qt::WindowStaysOnTopHint, as Qt::Tool keeps on top of the parent window, whereas Qt::WindowStaysOnTopHint keeps on top of all windows.