Differential D21527

Fix the 'Report bug' button being always disabled
ClosedPublic
Actions

Authored by dvratil on Jun 1 2019, 10:25 PM.

Details

Reviewers
dfaure
Group Reviewers
Plasma
Commits
R871:dd95de337e30: Fix the 'Report bug' button being always disabled
Summary

The commit d4ae04a7 has changed #define of HAVE_XMLRPCLCIENT
to #cmakedefine01 - since HAVE_XMLRPCCLIENT is not defined anywhere
in the CMakeFiles.txt, this lead to the 'Report bug' button being
unconditionally disabled at compile time.

Since KXmlRpcClient is a REQUIRED dependency (and has been for a while),
we can just remove the macro altogether.

BUG: 406606
FIXED-IN: 5.16.0

Test Plan

The 'Report bug' button is enabled

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Jun 1 2019, 10:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 1 2019, 10:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dvratil requested review of this revision.Jun 1 2019, 10:25 PM
dvratil edited the summary of this revision. (Show Details)Jun 1 2019, 10:28 PM
dfaure accepted this revision.Jun 2 2019, 6:51 AM
This revision is now accepted and ready to land.Jun 2 2019, 6:51 AM
Closed by commit R871:dd95de337e30: Fix the 'Report bug' button being always disabled (authored by dvratil). · Explain WhyJun 2 2019, 12:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/config-drkonqi.h.cmake (1 line)
Msrc/drkonqidialog.cpp (9 lines)

Diff 59019

View Options

src/config-drkonqi.h.cmake

Loading...
View Options

src/drkonqidialog.cpp

Loading...