Differential D21518

Fix infinite loop guard in case of duplicate UIDs
ClosedPublic
Actions

Authored by vkrause on Jun 1 2019, 8:29 AM.

Details

Reviewers
mlaurent
Commits
R76:d641eadd863f: Fix infinite loop guard in case of duplicate UIDs
Summary

In this case the prenodeByUid hash will not increase its size (thus not
fulfilling the outer loop condition), but an element is found nevertheless
(thus not triggering the loop guard). Now both use the same condition.

Diff Detail

Repository
R76 PIM: Event Views
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jun 1 2019, 8:29 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJun 1 2019, 8:29 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Jun 1 2019, 8:29 AM
mlaurent accepted this revision.Jun 2 2019, 7:47 AM
This revision is now accepted and ready to land.Jun 2 2019, 7:47 AM
Closed by commit R76:d641eadd863f: Fix infinite loop guard in case of duplicate UIDs (authored by vkrause). · Explain WhyJun 2 2019, 8:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/todo/incidencetreemodel.cpp (6 lines)

Diff 59006

View Options

src/todo/incidencetreemodel.cpp

Loading...