Differential D21516

Variables for column/row are switched for Profile - Initial Terminal Size
ClosedPublic
Actions

Authored by marten on May 31 2019, 7:12 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:1cecc8ae38ba: Variables for column/row are switched for Profile-Initial Terminal Size
R319:f95a46f58084: Variables for column/row are switched for Profile-Initial Terminal Size
Summary

This dialogue page has two spin boxes setting the initial terminal size.
They are no longer individually labelled, but the first one has suffix
"rows" and the second has "columns". However, they actually set
the columns and rows respectively. The default settings are 80 for
the first box and 24 for the second, which are obviously the column
and row settings.

Test Plan

Built Konsole with this change. Checked that the spin box suffixes
are "columns" and 'rows" respectively and agree with what they set.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.May 31 2019, 7:12 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMay 31 2019, 7:12 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
marten requested review of this revision.May 31 2019, 7:12 PM
hindenburg retitled this revision from Suffixes of Edit Profile - General - Initial Terminal Size don't agree with what they set to Variables for column/row are switched for Profile - Initial Terminal Size.Jun 1 2019, 4:06 PM
hindenburg edited the summary of this revision. (Show Details)
hindenburg edited the test plan for this revision. (Show Details)
hindenburg accepted this revision.Jun 1 2019, 4:24 PM
hindenburg added a subscriber: hindenburg.

Nice catch - thanks a lot.

This revision is now accepted and ready to land.Jun 1 2019, 4:24 PM
Closed by commit R319:1cecc8ae38ba: Variables for column/row are switched for Profile-Initial Terminal Size (authored by marten, committed by hindenburg). · Explain WhyJun 1 2019, 4:38 PM
This revision was automatically updated to reflect the committed changes.
hindenburg mentioned this in R319:47c4e399d3a6: Merge branch 'D21516' into 'master'.
hindenburg added a comment.Jun 1 2019, 4:43 PM

Since the move to invent, arc land doesn't work for me ATM - I need to re-arrange my system - I merged the branch in invent.

Revision Contents
Changeset List

PathPackages
Msrc/EditProfileDialog.cpp (4 lines)

Diff 58988

View Options

src/EditProfileDialog.cpp

Loading...