Differential D21513

queue load() after all deleteLater() in unload() are done
ClosedPublic
Actions

Authored by mart on May 31 2019, 4:38 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:b059097a5bc1: queue load() after all deleteLater() in unload() are done
Summary

Put load in queue of the event loop to wait for the whole set of containments to have been deleteLater(), as some like FolderView operate on singletons which can cause inconsistent states

Test Plan

now switching look and feel between 2 themes that use both FolderView
as desktop containment, the icons are still there

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.May 31 2019, 4:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 31 2019, 4:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.May 31 2019, 4:38 PM
davidedmundson accepted this revision.May 31 2019, 4:45 PM
This revision is now accepted and ready to land.May 31 2019, 4:45 PM
Closed by commit R120:b059097a5bc1: queue load() after all deleteLater() in unload() are done (authored by mart). · Explain WhyMay 31 2019, 4:48 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.May 31 2019, 4:49 PM

Stable branch?

Revision Contents
Changeset List

PathPackages
Mshell/shellcorona.cpp (3 lines)

Diff 58961

View Options

shell/shellcorona.cpp

Loading...