Differential D21507

Remove DefaultListItemBackground and MenuItem animation
ClosedPublic
Actions

Authored by GB_2 on May 30 2019, 5:46 PM.

Details

Reviewers
ngraham
mart
Group Reviewers
Plasma
VDG
Commits
R858:59d06ca5df04: Remove DefaultListItemBackground and MenuItem animation
Summary

This makes it consistent with the QWidget style.

Test Plan

Hover over QQC2 combobox items.

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Branch
remove-defaultlistitembackground-animation (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12296
Build 12314: arc lint + arc unit
GB_2 created this revision.May 30 2019, 5:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 30 2019, 5:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.May 30 2019, 5:46 PM
ngraham accepted this revision.May 30 2019, 6:22 PM
ngraham added a subscriber: ngraham.

Nice. Also needs to be done for dropdown menus in Kirigami; see Discover's "sources" pop-up menu for an example that's not affected by this (but probably should be...)

This revision is now accepted and ready to land.May 30 2019, 6:22 PM
GB_2 added a subscriber: mart.May 30 2019, 7:58 PM
In D21507#472295, @ngraham wrote:

Nice. Also needs to be done for dropdown menus in Kirigami; see Discover's "sources" pop-up menu for an example that's not affected by this (but probably should be...)

Hmm, I can't figure out how to fix that. @mart Can you help?

GB_2 added a comment.May 31 2019, 8:46 AM
In D21507#472356, @ngraham wrote:

I would guess that the code is somewhere in https://cgit.kde.org/kirigami.git/tree/src/controls/private/ActionButton.qml

Removing all animations there doesn't affect it :(

mart accepted this revision.May 31 2019, 12:37 PM
mart added a comment.May 31 2019, 12:43 PM

it's MenuI

In D21507#472376, @GB_2 wrote:
In D21507#472356, @ngraham wrote:

I would guess that the code is somewhere in https://cgit.kde.org/kirigami.git/tree/src/controls/private/ActionButton.qml

Removing all animations there doesn't affect it :(

no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed

GB_2 updated this revision to Diff 58947.May 31 2019, 1:17 PM

Change MenuItem too

GB_2 retitled this revision from Remove DefaultListItemBackground animation to Remove DefaultListItemBackground and MenuItem animation.May 31 2019, 1:17 PM
In D21507#472482, @mart wrote:

no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed

Thanks!

ngraham accepted this revision.May 31 2019, 1:29 PM
GB_2 added a comment.EditedMay 31 2019, 1:31 PM
In D21507#472482, @mart wrote:

no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed

Ok, but if the DefaultListItemBackground animation there doesn't get removed there is still an animation in the sidebar of SySe and Discover.

Closed by commit R858:59d06ca5df04: Remove DefaultListItemBackground and MenuItem animation (authored by GB_2). · Explain WhyMay 31 2019, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58947

View Options

org.kde.desktop/MenuItem.qml

Loading...
View Options

org.kde.desktop/private/DefaultListItemBackground.qml

Loading...