Remove DefaultListItemBackground and MenuItem animation
ClosedPublic

Authored by GB_2 on Thu, May 30, 5:46 PM.

Details

Summary

This makes it consistent with the QWidget style.

Test Plan

Hover over QQC2 combobox items.

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Thu, May 30, 5:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, May 30, 5:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Thu, May 30, 5:46 PM
ngraham accepted this revision.Thu, May 30, 6:22 PM
ngraham added a subscriber: ngraham.

Nice. Also needs to be done for dropdown menus in Kirigami; see Discover's "sources" pop-up menu for an example that's not affected by this (but probably should be...)

This revision is now accepted and ready to land.Thu, May 30, 6:22 PM
GB_2 added a subscriber: mart.Thu, May 30, 7:58 PM

Nice. Also needs to be done for dropdown menus in Kirigami; see Discover's "sources" pop-up menu for an example that's not affected by this (but probably should be...)

Hmm, I can't figure out how to fix that. @mart Can you help?

GB_2 added a comment.Fri, May 31, 8:46 AM

Removing all animations there doesn't affect it :(

mart accepted this revision.Fri, May 31, 12:37 PM
mart added a comment.Fri, May 31, 12:43 PM

it's MenuI

In D21507#472376, @GB_2 wrote:

Removing all animations there doesn't affect it :(

no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed

GB_2 updated this revision to Diff 58947.Fri, May 31, 1:17 PM

Change MenuItem too

GB_2 retitled this revision from Remove DefaultListItemBackground animation to Remove DefaultListItemBackground and MenuItem animation.Fri, May 31, 1:17 PM
In D21507#472482, @mart wrote:

no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed

Thanks!

ngraham accepted this revision.Fri, May 31, 1:29 PM
GB_2 added a comment.EditedFri, May 31, 1:31 PM
In D21507#472482, @mart wrote:

no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed

Ok, but if the DefaultListItemBackground animation there doesn't get removed there is still an animation in the sidebar of SySe and Discover.

This revision was automatically updated to reflect the committed changes.