Differential D21492

Remove double look-ups
ClosedPublic
Actions

Authored by apol on May 29 2019, 10:57 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R120:1abcdd51839d: Remove double look-ups
Test Plan

plasmashell still works fine

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.May 29 2019, 10:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 29 2019, 10:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.May 29 2019, 10:57 PM
broulik accepted this revision.May 30 2019, 10:33 AM
broulik added a subscriber: broulik.
broulik added inline comments.
shell/shellcorona.cpp
1068

Compare with end() since you're not using constFind()

This revision is now accepted and ready to land.May 30 2019, 10:33 AM
Closed by commit R120:1abcdd51839d: Remove double look-ups (authored by apol). · Explain WhyMay 30 2019, 10:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/shellcorona.cpp (31 lines)

Diff 58896

View Options

shell/shellcorona.cpp

Loading...