Differential D21489

Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper
Changes PlannedPublic
Actions

Authored by xnick on May 29 2019, 9:47 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Arch uses the mkinitcpio script to create the init image. Plymouthhelper
expects update-initramfs. Added a case to check if mkinitcpio exists,
and, if so, use it.

Diff Detail

Repository
R258 Plymouth KCM
Lint
Lint Skipped
Unit
Unit Tests Skipped
xnick created this revision.May 29 2019, 9:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 29 2019, 9:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
xnick requested review of this revision.May 29 2019, 9:47 PM
ngraham added a subscriber: ngraham.May 29 2019, 9:50 PM

Instead of just using it when it's there, it would probably make more sense to add a CMake variable that allows the distro to choose which code path to use. See for example https://cgit.kde.org/kdenetwork-filesharing.git/tree/CMakeLists.txt#n50

xnick added a comment.May 29 2019, 9:52 PM

Sounds good.

I'll take a look on how to adapt it tomorrow.

Thanks!

xnick planned changes to this revision.May 29 2019, 9:53 PM
• lavender added a subscriber: • lavender.May 30 2019, 12:09 AM
In D21489#471864, @ngraham wrote:

Instead of just using it when it's there, it would probably make more sense to add a CMake variable that allows the distro to choose which code path to use. See for example https://cgit.kde.org/kdenetwork-filesharing.git/tree/CMakeLists.txt#n50

Maybe both options? I'm thinking of distros that package multiple or users that change their distro's default.

arojas added a subscriber: arojas.May 30 2019, 6:21 AM

Just a FYI, Arch is going switch away from mkinitcpio https://lists.archlinux.org/pipermail/arch-dev-public/2019-May/029570.html (Not saying this wouldn't be useful for the time being)

Revision Contents
Changeset List

PathPackages
Msrc/helper.cpp (28 lines)

Diff 58871

View Options

src/helper.cpp

Loading...