Use nullptr
AbandonedPublic

Authored by fmonteiro on May 29 2019, 9:26 PM.

Details

Reviewers
rempt
Group Reviewers
Krita

Diff Detail

Repository
R37 Krita
Branch
nullptr (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12258
Build 12276: arc lint + arc unit
fmonteiro created this revision.May 29 2019, 9:26 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptMay 29 2019, 9:26 PM
Restricted Application added a project: Krita. · View Herald Transcript
fmonteiro requested review of this revision.May 29 2019, 9:26 PM
rempt added a comment.May 30 2019, 5:24 AM

Hi,

I'm sorry, but we did decide (and document that decision) not to use nullptr in Krita: https://docs.krita.org/en/untranslatable_pages/modern_cpp_in_krita.html#nullptr

I still feel that's the right decision from the viewpoint of development continuity. nullptr has no advantages, and would still mess up the git history and make it hard to keep working on existing long-running feature branches.

fmonteiro abandoned this revision.May 30 2019, 2:55 PM