Differential D21482

[Notifications] Delay configuring events
ClosedPublic
Actions

Authored by broulik on May 29 2019, 2:25 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R119:aed7f5979ec7: [Notifications] Delay configuring events
Summary

In Component.onCompleted we might not have a window yet which we need to make the events configuration dialog transient to.

Test Plan
  • Clicking configure button on configure button of kde application no longer spawns two task bar entries as the events config dialog is now properly transient to the kcm dialog

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.May 29 2019, 2:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 29 2019, 2:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 29 2019, 2:25 PM
apol accepted this revision.May 29 2019, 2:31 PM
This revision is now accepted and ready to land.May 29 2019, 2:31 PM
Closed by commit R119:aed7f5979ec7: [Notifications] Delay configuring events (authored by broulik). · Explain WhyMay 29 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58843

View Options

kcms/notifications/package/contents/ui/SourcesPage.qml

Loading...