Differential D21474

[Notifications] Spawn new notification if one to replace doesn't exist
ClosedPublic
Actions

Authored by broulik on May 29 2019, 7:39 AM.

Details

Reviewers
bugseforuns
apol
Group Reviewers
Plasma
Commits
R120:17f1834e98ae: [Notifications] Spawn new notification if one to replace doesn't exist
Summary

Since the Notification Server knows nothing about what notifications were sent, it tells us a notification was replaced and uses the ID supplied by the application. Only in the model we then realize it didn't exist.
This means we will potentially reuse the notification ID sent by the application as we just increment a counter.
However, in practice I haven't encountered this issue before (maybe we just never noticed?) but I think this is an acceptable workaround.

BUG: 407881
FIXED-IN: 5.16.0

Test Plan

Sent a notification with replaces_id 1337 and still got a notification.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 29 2019, 7:39 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 29 2019, 7:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 29 2019, 7:39 AM
apol accepted this revision.May 29 2019, 10:46 AM
This revision is now accepted and ready to land.May 29 2019, 10:46 AM
Closed by commit R120:17f1834e98ae: [Notifications] Spawn new notification if one to replace doesn't exist (authored by broulik). · Explain WhyMay 29 2019, 11:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58835

View Options

libnotificationmanager/notificationsmodel.cpp

Loading...