IMAP: Option to use system proxy settings (Configuration and GUI)
ClosedPublic

Authored by marten on May 28 2019, 3:43 PM.

Details

Summary

This is to provide an explicit option to not use the system proxy setting for IMAP connections, as described in T7430. This was originally intended to be implemented for IMAP as well as SMTP and POP3, but it got overlooked. https://bugs.kde.org/show_bug.cgi?id=407685 refers.

D21463 implements the proxy option in the IMAP core library. This is the GUI for the setting, which appears as an additional option in the "Advanced" tab of the account settings dialogue.

Test Plan

Built pimruntime with this change. Verified that the account option is correctly saved in the agent configuration file and that it controls whether the IMAP resource connects via the proxy.

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.May 28 2019, 3:43 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 28 2019, 3:43 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
marten requested review of this revision.May 28 2019, 3:43 PM
marten edited the summary of this revision. (Show Details)
marten edited the summary of this revision. (Show Details)
marten updated this revision to Diff 58824.May 29 2019, 8:43 AM

KIMAP required version updated

dvratil requested changes to this revision.May 31 2019, 11:59 AM
dvratil added a subscriber: dvratil.
dvratil added inline comments.
resources/imap/setupserverview_desktop.ui
614

Indentation

This revision now requires changes to proceed.May 31 2019, 11:59 AM
marten updated this revision to Diff 58956.May 31 2019, 3:04 PM
marten marked an inline comment as done.

Tab converted to spaces

dvratil accepted this revision.Jun 8 2019, 11:49 AM
This revision is now accepted and ready to land.Jun 8 2019, 11:49 AM
This revision was automatically updated to reflect the committed changes.

can you update the kmail docbook accordingly?