[aurorae] Allow themes to specify resize only borders
AbandonedPublic
Actions

Authored by zzag on May 28 2019, 2:28 PM.

Details

Reviewers

None

Group Reviewers

Summary

There are a few borderless Aurorae decoration themes. All they suffer
from the same issue: it's quite difficult to resize windows.

This change introduces ResizeOnlyBorder* attributes that can be used by
theme creators to specify extents of resizable area outside each decorated
client.

BUG: 408036

Diff Detail

Repository

R108 KWin

Branch

unset-resize-only-borders

Lint

Lint Errors

Excuse: false positive

Severity	Location	Code	Message
Error	plugins/kdecorations/aurorae/theme-description:64	MERGECONFLICT1	Unresolved merge conflict

Unit

No Unit Test Coverage

Build Status

Buildable 12227
Build 12245: arc lint + arc unit

zzag created this revision.May 28 2019, 2:28 PM

Restricted Application added a project: KWin. · View Herald TranscriptMay 28 2019, 2:28 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.May 28 2019, 2:28 PM

Harbormaster completed remote builds in B12227: Diff 58790.May 28 2019, 2:28 PM

zzag edited the summary of this revision. (Show Details)May 28 2019, 2:56 PM

zzag edited the summary of this revision. (Show Details)May 28 2019, 3:01 PM

Hmm, I've given this revision another thought and now I'm not sure whether maximizedExtendedBorders makes sense. Initial reasoning was to allow resizing maximized clients with no borders, but this feature is useless if you have only one monitor because resize extents will be off screen.

Any thoughts?

Perhaps maximizedExtendedBorders doesn't make sense.

zzag abandoned this revision.Aug 30 2019, 8:38 PM

Revision Contents
Changeset List

			Path	Packages
M			plugins/kdecorations/aurorae/src/aurorae.h (5 lines)
M			plugins/kdecorations/aurorae/src/aurorae.cpp (91 lines)
M			plugins/kdecorations/aurorae/src/lib/auroraetheme.h (17 lines)
M			plugins/kdecorations/aurorae/src/lib/auroraetheme.cpp (71 lines)
M			plugins/kdecorations/aurorae/src/lib/themeconfig.h (32 lines)
M			plugins/kdecorations/aurorae/src/lib/themeconfig.cpp (10 lines)
M			plugins/kdecorations/aurorae/src/qml/Decoration.qml (3 lines)
M			plugins/kdecorations/aurorae/src/qml/aurorae.qml (8 lines)
M			plugins/kdecorations/aurorae/theme-description (3 lines)