Differential D21460

[Notifications] Group applications with same display name but no desktop entry
ClosedPublic
Actions

Authored by broulik on May 28 2019, 12:46 PM.

Details

Reviewers
hein
ngraham
Group Reviewers
Plasma
Commits
R120:08b027f1124b: [Notifications] Group applications with same display name but no desktop entry
Summary

The specification says appName should be the display name of the application.
An application may not send a desktop name at which point we have no other way of identifying it.

Test Plan

VLC notifications are grouped together now (I fixed vlc in a newer version to send such a hint) but there might also be other applications and scripts that could benefit from this.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 28 2019, 12:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 28 2019, 12:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 28 2019, 12:46 PM
ngraham accepted this revision.May 28 2019, 1:59 PM
This revision is now accepted and ready to land.May 28 2019, 1:59 PM
Closed by commit R120:08b027f1124b: [Notifications] Group applications with same display name but no desktop entry (authored by broulik). · Explain WhyMay 28 2019, 2:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58789

View Options

libnotificationmanager/notificationgroupingproxymodel.cpp

Loading...