[System Tray] Ignore services that start with a colon (:)
ClosedPublic

Authored by broulik on May 28 2019, 10:35 AM.

Details

Summary

Bus names that start with a colon (':') character are unique connection names rather than well-known bus names you want to be listening for.
Since the same code path is used for initial setup as is for detecting services at runtime, we would needlessly iterate the list of known dbus-activatable services as well as apply a regular expression on them for all unique connection names wasting some cycles.

Test Plan

The list of dbus activatable tasks is iterated 75 times now on startup rather than 170 times

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 28 2019, 10:35 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 28 2019, 10:35 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 28 2019, 10:35 AM
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik edited the summary of this revision. (Show Details)
broulik edited the summary of this revision. (Show Details)May 28 2019, 10:39 AM
davidedmundson accepted this revision.May 28 2019, 2:03 PM
This revision is now accepted and ready to land.May 28 2019, 2:03 PM
This revision was automatically updated to reflect the committed changes.