Differential D21434

[Notifications KCM] Try both model indices
ClosedPublic
Actions

Authored by broulik on May 27 2019, 6:53 PM.

Details

Reviewers
nicolasfella
davidedmundson
Group Reviewers
Plasma
Commits
R119:85359e1d4b22: [Notifications KCM] Try both model indices
Summary

We prefer applicatons over services, however, when configuring a KDE application we get passed both an application and a service. That application might be NoDisplay and then we end up not finding an index and event configuration files.

Test Plan

5.16 branch

I can now configure KDE Connect notifications by clicking the configure icon on the notification.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.May 27 2019, 6:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 27 2019, 6:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 27 2019, 6:53 PM
nicolasfella added a comment.May 27 2019, 7:45 PM

Works for me
+1

davidedmundson accepted this revision.May 27 2019, 8:27 PM
This revision is now accepted and ready to land.May 27 2019, 8:27 PM
Closed by commit R119:85359e1d4b22: [Notifications KCM] Try both model indices (authored by broulik). · Explain WhyMay 28 2019, 8:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58737

View Options

kcms/notifications/package/contents/ui/SourcesPage.qml

Loading...