Do screen filtering by screen geometry rather than number.
ClosedPublic
Actions

Authored by hein on Jul 12 2016, 8:55 AM.

Details

Reviewers

mart
graesslin

Group Reviewers

Plasma

Commits

R120:332b96b3632d: Do screen filtering by screen geometry rather than number.
R871:332b96b3632d: Do screen filtering by screen geometry rather than number.

Summary

Avoids problems stemming from libtaskmanager and plasma-framework's
AppletInterface::screen numbering screens differently (QScreen order
vs. who knows what).

CCBUG:365246

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein updated this revision to Diff 5092.Jul 12 2016, 8:55 AM

hein retitled this revision from to Do screen filtering by screen geometry rather than number..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added reviewers: Plasma, graesslin, mart.

hein added a subscriber: plasma-devel.

Restricted Application added a project: Plasma. · View Herald TranscriptJul 12 2016, 8:55 AM

to me looking at it is ok

mart accepted this revision.Jul 12 2016, 9:02 AM

mart edited edge metadata.

This revision is now accepted and ready to land.Jul 12 2016, 9:02 AM

Closed by commit R120:332b96b3632d: Do screen filtering by screen geometry rather than number. (authored by hein). · Explain WhyJul 12 2016, 9:10 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libtaskmanager/abstracttasksmodel.h (2 lines)
M			libtaskmanager/startuptasksmodel.cpp (6 lines)
M			libtaskmanager/taskfilterproxymodel.h (25 lines)
M			libtaskmanager/taskfilterproxymodel.cpp (27 lines)
M			libtaskmanager/taskgroupingproxymodel.cpp (2 lines)
M			libtaskmanager/tasksmodel.h (24 lines)
M			libtaskmanager/tasksmodel.cpp (12 lines)
M			libtaskmanager/tasktools.h (9 lines)
M			libtaskmanager/tasktools.cpp (33 lines)
M			libtaskmanager/waylandtasksmodel.cpp (2 lines)
M			libtaskmanager/xwindowtasksmodel.cpp (37 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5092	d1210f5		Jul 12 2016, 8:55 AM	★	★
Diff 2	5093	d1210f5	rPLASMAWORKSPACE332b96b3632d0fc4b3bbd21907127093f0988e45	Jul 12 2016, 8:55 AM	★	★