Differential D21424

Log all DDP messages sent and received in RUQOLA_LOGFILE, if set.
ClosedPublic
Actions

Authored by dfaure on May 27 2019, 8:12 AM.

Details

Reviewers
mlaurent
Commits
R865:53cf039662cf: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set.
Summary

This was all messages are in the logfile, where I expected them to be, not just REST messages.

Test Plan

export RUQOLA_LOGFILE=/tmp/ruqola.log

Diff Detail

Repository
R865 Ruqola
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12200
Build 12218: arc lint + arc unit
dfaure requested review of this revision.May 27 2019, 8:12 AM
dfaure created this revision.
dfaure updated this revision to Diff 58713.May 27 2019, 8:54 AM

Fix crash when RUQOLA_LOGFILE isn't set

mlaurent accepted this revision.May 27 2019, 11:12 AM

just adding nullptr and +2 :)

src/ruqolacore/ruqolawebsocket.h
51

nullptr

This revision is now accepted and ready to land.May 27 2019, 11:12 AM
dfaure added inline comments.May 27 2019, 11:43 AM
src/ruqolacore/ruqolawebsocket.h
51

If you want, but I set this member variable in the ctor init list, so it doesn't change anything.

mlaurent added inline comments.May 27 2019, 7:19 PM
src/ruqolacore/ruqolawebsocket.h
51

Yep I know but I use this coding style by default :)

dfaure updated this revision to Diff 58740.May 27 2019, 7:26 PM

initialize to nullptr in the header

mlaurent accepted this revision.May 27 2019, 7:39 PM
dfaure closed this revision.May 27 2019, 8:43 PM

Revision Contents
Changeset List

Diff 58740

View Options

src/ruqolacore/ddpapi/ddpclient.cpp

Loading...
View Options

src/ruqolacore/ruqolawebsocket.h

Loading...
View Options

src/ruqolacore/ruqolawebsocket.cpp

Loading...