[Notifications] Fix translations in popup
ClosedPublic
Actions

Authored by broulik on May 27 2019, 7:15 AM.

Details

Reviewers

aacid
yurchor

Group Reviewers

Plasma

Commits

R120:41e41b194c1f: [Notifications] Fix translations in popup

Summary

The popup is a pure QML singleton and as such doesn't inherit the i18n context from the applet. Use i18nd explicitly.

BUG: 407927

Test Plan

Stuff in popup is translated properly now

main.qml and FullRepresentation.qml aren't changed as they are items that are used in the applet like normal.

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.May 27 2019, 7:15 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMay 27 2019, 7:15 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.May 27 2019, 7:15 AM

Thanks.

This revision is now accepted and ready to land.May 27 2019, 7:20 AM

Closed by commit R120:41e41b194c1f: [Notifications] Fix translations in popup (authored by broulik). · Explain WhyMay 27 2019, 7:46 AM

This revision was automatically updated to reflect the committed changes.

This does not fix all files.

Which files are you missing? main.qml and FullRepresentation.qml aren't changed on purpose as it's not neccessary there.

In D21422#470522, @broulik wrote:

Which files are you missing? main.qml and FullRepresentation.qml aren't changed on purpose as it's not neccessary there.

We also need this patch.

plasma-workspace-fix.patch10 KBDownload

In D21422#470534, @victorr wrote:

In D21422#470522, @broulik wrote:

Which files are you missing? main.qml and FullRepresentation.qml aren't changed on purpose as it's not neccessary there.

We also need this patch.
plasma-workspace-fix.patch10 KBDownload

It is possible that I am mistaken.
Need to check again.
Today, a little later, check it out.

In D21422#470541, @victorr wrote:

We also need this patch.
plasma-workspace-fix.patch10 KBDownload

It is possible that I am mistaken.
Need to check again.
Today, a little later, check it out.

I was wrong.
Patch is not needed.
Everything is working.
I'm sorry.

Revision Contents
Changeset List

			Path	Packages
M			applets/notifications/package/contents/ui/EditContextMenu.qml (6 lines)
M			applets/notifications/package/contents/ui/JobDetails.qml (14 lines)
M			applets/notifications/package/contents/ui/JobItem.qml (16 lines)
M			applets/notifications/package/contents/ui/NotificationHeader.qml (16 lines)
M			applets/notifications/package/contents/ui/NotificationItem.qml (10 lines)
M			applets/notifications/package/contents/ui/ThumbnailStrip.qml (2 lines)