Tcsh: fix operators and keywords
ClosedPublic
Actions

Authored by jpoelen on May 26 2019, 9:39 PM.

Details

Reviewers

dhaumann
cullmann

Group Reviewers

Framework: Syntax Highlighting

Commits

R216:4d2329e3f63e: Tcsh: fix operators and keywords

Summary

missing foreach and end
fix folding with if (expr) cmd
missing != with [ ... ]
rules for arithmetic comparison
add dsControlFlow style
[[ ... ]] does not exists

Diff Detail

Repository

R216 Syntax Highlighting

Branch

fix_tcsh (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12180
Build 12198: arc lint + arc unit

jpoelen requested review of this revision.May 26 2019, 9:39 PM

jpoelen created this revision.

Harbormaster completed remote builds in B12180: Diff 58696.May 26 2019, 9:39 PM

Change looks reasonable + test case => thanks, please push

This revision is now accepted and ready to land.May 27 2019, 5:45 AM

I forgot to ask about running the tests. Is it normal that system syntax files take precedence if we have an index.katesyntax? Currently I have to run the tests by setting the environment variable XDG_DATA_DIRS.

Closed by commit R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored by jpoelen). · Explain WhyMay 27 2019, 9:03 PM

This revision was automatically updated to reflect the committed changes.

Actually the resource should be recreated on syntax file changes and be used.

OK I understand. Initially I had not changed the version number of txsh.xml and it is based on the reference in /usr/share/org.kde.syntax-highlighting/syntax/index.katesyntax rather than in the repository.
And the fact that the versions in the index file were newer than my xml files... I had errors with highlight.fish.

Revision Contents
Changeset List

		Path
A	M	autotests/folding/highlight.tcsh.fold (42 lines)
A	M	autotests/html/highlight.tcsh.html (49 lines)
A	M	autotests/input/highlight.tcsh (42 lines)
A	M	autotests/reference/highlight.tcsh.ref (42 lines)
M		data/syntax/tcsh.xml (91 lines)