Differential D21417

[ActionListItem] Make QML imports and tooltip consistent
ClosedPublic
Actions

Authored by GB_2 on May 26 2019, 4:46 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10862: Make QML imports consistent
Commits
R134:7b778dbe90fe: [ActionListItem] Make QML imports and tooltip consistent
Summary

T10862 and T10873

Test Plan

The tooltip now behaves correctly.

Diff Detail

Repository
R134 Discover Software Store
Branch
actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12189
Build 12207: arc lint + arc unit
GB_2 created this revision.May 26 2019, 4:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 26 2019, 4:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.May 26 2019, 4:46 PM
GB_2 added a comment.May 27 2019, 6:00 AM
In D21417#470381, @apol wrote:

But BasicListItem already is a Control.
https://doc.qt.io/qt-5/qml-qtquick-controls2-itemdelegate.html

Ok, weird. If I do it without the Control it shows this error: qrc:/qml/ActionListItem.qml:44 Cannot assign object to list property "_basicDefault"

apol added a comment.May 27 2019, 10:39 AM

Ok, weird. If I do it without the Control it shows this error: qrc:/qml/ActionListItem.qml:44 Cannot assign object to list property "_basicDefault"

Try putting it into a property so that it's not assigned as the parent's default item.

GB_2 updated this revision to Diff 58720.May 27 2019, 11:56 AM

Remove workaround and put tooltip into property

GB_2 updated this revision to Diff 58721.EditedMay 27 2019, 11:58 AM

Remove unneeded parent property

apol accepted this revision.May 27 2019, 6:18 PM

Otherwise it's good to go.

discover/qml/ActionListItem.qml
44

It has an indentation too much.

This revision is now accepted and ready to land.May 27 2019, 6:18 PM
GB_2 updated this revision to Diff 58733.May 27 2019, 6:41 PM

Clean indentation

GB_2 marked an inline comment as done.May 27 2019, 6:41 PM
Closed by commit R134:7b778dbe90fe: [ActionListItem] Make QML imports and tooltip consistent (authored by GB_2). · Explain WhyMay 27 2019, 6:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/ActionListItem.qml (10 lines)

Diff 58721

View Options

discover/qml/ActionListItem.qml

Loading...