Details
Details
- Reviewers
apol - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10862: Make QML imports consistent
- Commits
- R134:7b778dbe90fe: [ActionListItem] Make QML imports and tooltip consistent
The tooltip now behaves correctly.
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
But BasicListItem already is a Control.
https://doc.qt.io/qt-5/qml-qtquick-controls2-itemdelegate.html
Comment Actions
Ok, weird. If I do it without the Control it shows this error: qrc:/qml/ActionListItem.qml:44 Cannot assign object to list property "_basicDefault"
Comment Actions
Ok, weird. If I do it without the Control it shows this error: qrc:/qml/ActionListItem.qml:44 Cannot assign object to list property "_basicDefault"
Try putting it into a property so that it's not assigned as the parent's default item.
Comment Actions
Otherwise it's good to go.
discover/qml/ActionListItem.qml | ||
---|---|---|
44–46 | It has an indentation too much. |