Disable smoothing thumbnails in LowResourceUsageMode
ClosedPublic

Authored by tommo on May 25 2019, 3:36 PM.

Details

Summary

If LowResourceUsageMode is enabled, do not waste resources on smoothing-scaling small thumbnails.

Depends on D21406

Diff Detail

Repository
R260 Gwenview
Lint
Lint Skipped
Unit
Unit Tests Skipped
tommo requested review of this revision.May 25 2019, 3:36 PM
tommo created this revision.
tommo added a comment.May 25 2019, 3:39 PM

...also a blurred thumbnail suggests that the image is defocused.

ngraham requested changes to this revision.Jun 28 2019, 2:36 PM
ngraham added inline comments.
lib/thumbnailview/thumbnailview.cpp
670

misspelling cause a compilation failure:

/home/nate/kde/src/gwenview/lib/thumbnailview/thumbnailview.cpp:670:25: error: ‘lowRessourceUsageMode’ is not a member of ‘Gwenview::GwenviewConfig’
     if (GwenviewConfig::lowRessourceUsageMode() && thumbnail.mRough && !d->mSmoothThumbnailQueue.contains(url)) {
                         ^~~~~~~~~~~~~~~~~~~~~
This revision now requires changes to proceed.Jun 28 2019, 2:36 PM
tommo updated this revision to Diff 60797.Jun 28 2019, 5:05 PM
ngraham accepted this revision.Jun 28 2019, 6:00 PM

Thanks!

This revision is now accepted and ready to land.Jun 28 2019, 6:00 PM
ngraham closed this revision.Jun 28 2019, 6:14 PM