Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode

Authored by tommo on May 25 2019, 3:34 PM.



DeleteThumbnailCacheOnExit has been promoted to a low-resource-usage mode. Reflect that change in the code.

Diff Detail

R260 Gwenview
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
tommo requested review of this revision.May 25 2019, 3:34 PM
tommo created this revision.
tommo updated this revision to Diff 58657.May 25 2019, 3:36 PM
tommo retitled this revision from Rename DeleteThumbnailCacheOnExit -> LowRessourceUsageMode to Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
tommo edited the summary of this revision. (Show Details)
ngraham requested changes to this revision.May 26 2019, 3:53 PM
ngraham added a subscriber: ngraham.

By renaming the config name in gwenviewconfig.kcfg, you'll reset existing users' preferences. Whenever you want to rename a key in a config file, you need to ship a kconfig update script to update existing users' config files. Look at the contents of the kconf_update folder in the source tree for an example of an existing one. And here's the documentation:

This revision now requires changes to proceed.May 26 2019, 3:53 PM
tommo added a comment.Jun 1 2019, 11:46 AM

Need to postpone this until end of June.

ngraham added inline comments.Jun 1 2019, 10:08 PM

Alternatively you can just not rename this key in the config file and then you won't have to do all that kconf update stuff.

tommo added inline comments.Jun 2 2019, 5:51 AM

Ok, but since I've also renamed it in gwenviewconfig.kcfg, wouldn't that loose the connection between that checkBox and the GwenviewConfig::lowResourceUsageMode() property?

ngraham added inline comments.Jun 3 2019, 3:41 PM

Oh right, never mind

tommo updated this revision to Diff 60496.Jun 23 2019, 2:37 PM

Added kconfig update script. Tested with make install and works as expected.

ngraham accepted this revision.Jun 25 2019, 9:45 AM

Thanks, this is perfect.

This revision is now accepted and ready to land.Jun 25 2019, 9:45 AM
This revision was automatically updated to reflect the committed changes.