require cmake 3.8 and declare the version into a single place
ClosedPublic
Actions

Authored by mgallien on May 25 2019, 2:26 PM.

Details

Reviewers

rikmills
ngraham

Group Reviewers

Elisa

Commits

R255:374e0e00a5f2: require cmake 3.8 and declare the version into a single place

Summary

to allow simpler management of the version, only declare it in
CMakeLists.txt project command and use that to set it in the code

require the minimal version needed to get c++17

Test Plan

tests are OK

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.May 25 2019, 2:26 PM

mgallien created this revision.

Harbormaster completed remote builds in B12157: Diff 58649.May 25 2019, 2:26 PM

Instead of reusing config-upnp-qt.h (whose name seems a bit off, considering what that file contains), IMHO it is better to use a separate version header.
You can use the ECMSetupVersion module from ECM for this.

use ecm_setup_version to set the project version

Harbormaster completed remote builds in B12160: Diff 58652.May 25 2019, 3:03 PM

In D21404#469907, @pino wrote:

Instead of reusing config-upnp-qt.h (whose name seems a bit off, considering what that file contains), IMHO it is better to use a separate version header.
You can use the ECMSetupVersion module from ECM for this.

Thanks a lot for the suggestion. Your help is very valuable.

ngraham accepted this revision.May 26 2019, 3:36 AM

This revision is now accepted and ready to land.May 26 2019, 3:36 AM

Closed by commit R255:374e0e00a5f2: require cmake 3.8 and declare the version into a single place (authored by mgallien). · Explain WhyMay 26 2019, 8:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (10 lines)
M			src/audiowrapper_libvlc.cpp (4 lines)
M			src/localFileConfiguration/localfileconfiguration.cpp (4 lines)
M			src/main.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58649	e23fdcb		May 25 2019, 2:26 PM	★	★
Diff 2	58652	e23fdcb	- use ecm_setup_version to set the project version	May 25 2019, 3:03 PM	★	★
Diff 3	58693	e23fdcb	R255:374e0e00a5f211a005ae40bd73d8bfa22e074626	May 26 2019, 8:04 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
80cafbc1032c	376fb45a11a7	aa61aeec506a	Matthieu Gallien	use ecm_setup_version to set the project version (Show More…)	May 25 2019, 3:02 PM
aa61aeec506a	8444b6378278	e23fdcb93a3c	Matthieu Gallien	require cmake 3.8 and declare the version into a single place (Show More…)	May 25 2019, 2:22 PM

Diff 58693

View Options

CMakeLists.txt

View Options

src/audiowrapper_libvlc.cpp

View Options

src/localFileConfiguration/localfileconfiguration.cpp

View Options

require cmake 3.8 and declare the version into a single placeClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 58693

CMakeLists.txt

src/audiowrapper_libvlc.cpp

src/localFileConfiguration/localfileconfiguration.cpp

src/main.cpp

require cmake 3.8 and declare the version into a single place
ClosedPublic
Actions

Revision Contents
Changeset List