use org.freedesktop.appstream-glib package to validate appstream data
Needs ReviewPublic

Authored by mgallien on May 24 2019, 1:22 PM.

Details

Reviewers
aacid
yurchor
apol
Summary

should help having the same validation than the one done by flathub

related to D21242 and D21243

Test Plan

A test with Elisa allows validation tu succeed

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12140
Build 12158: arc lint + arc unit
mgallien created this revision.May 24 2019, 1:22 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptMay 24 2019, 1:22 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
mgallien requested review of this revision.May 24 2019, 1:22 PM
apol requested changes to this revision.May 24 2019, 7:26 PM

How about we test against both?

And maybe it should be using appstream-util validate instead of forcing it through flatpak?
It will make it easier to be able to run it in build.kde.org.

This revision now requires changes to proceed.May 24 2019, 7:26 PM

Aleix is correct, Flatpak commands are not possible within the CI environment (as Docker is heavily locked down, and the containerisation and other isolation measures that Flatpak tries to take are locked out as a consequence)
Not to mention that Flatpak is Linux only as well, while Appstream data isn't applicable to multiple platforms.

mgallien updated this revision to Diff 58628.May 25 2019, 9:40 AM
  • use appstream-util and appstreamcli to validate appdata file
In D21381#469617, @apol wrote:

How about we test against both?

I have just pushed a new diff to do that.
I am not sure if it desirable to keep appstreamcli test given it fails to validate files that are validated by flathub and appstream-utils (without flathub patches).

And maybe it should be using appstream-util validate instead of forcing it through flatpak?
It will make it easier to be able to run it in build.kde.org.

I would like to also get an extra test to do that on setup where flatpak is available given that flathub uses a patched appstream-utils with relaxed validation constraints.