Closes T8755
Details
- Reviewers
mart filipf - Group Reviewers
VDG Plasma - Maniphest Tasks
- T8755: Use colors from the system colorscheme for the Task Manager's accent color in Breeze Light/Dark desktop themes
- Commits
- R242:fb8f02de76d5: Make Breeze Light/Dark use more system colors
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
the idea is kinda nice and with some schemes it will work just perfect...
however i think it risks a lot of having loss in contrast on certain color schems with your patch try for instance breezedark and the honeycomb system theme, the current task highlight would probably almost disappear
This is bringing it in line with Breeze Light which already has the color schemes influencing the taskbar color. I tested with honeycomb and it seemed to work fine.
So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good solution, +1 for the idea.
I gave it a quick spin with Breeze Dark however and it's just not picking up some color schemes. It remains stuck on the colors of some previous scheme that worked. This seems to be random and may be a bug originating elsewhere so I'm hitting accept.
Actually, Breeze Light should have had the same problem as Breeze Dark. It's Breeze that should have already been adapting to the system colorscheme because it didn't have any colors defined.
After changing the system colorscheme, did you try restarting plasmashell or switching to a different desktop theme and switching back? I'll admit, it's a bit janky, but it should work if you do that. It definitely seems like a bug that originates from elsewhere.
Restarting plasmashell yes, switching to a different theme nope. But I did now and that seems to be working.
It's very wonky but what worked for me was: change the desktop theme, not the look and feel, then change the color scheme to the one you want and finally change the desktop theme to Breeze Dark