Make Breeze Light/Dark use more system colors
ClosedPublic

Authored by ndavis on May 24 2019, 6:17 AM.

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
less-custom-colors (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12116
Build 12134: arc lint + arc unit
ndavis created this revision.May 24 2019, 6:17 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 24 2019, 6:17 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.May 24 2019, 6:17 AM

Tested and it looks good to me

mart added a comment.May 24 2019, 3:04 PM

the idea is kinda nice and with some schemes it will work just perfect...
however i think it risks a lot of having loss in contrast on certain color schems with your patch try for instance breezedark and the honeycomb system theme, the current task highlight would probably almost disappear

lavender added a comment.EditedMay 24 2019, 3:20 PM
In D21378#469517, @mart wrote:

the idea is kinda nice and with some schemes it will work just perfect...
however i think it risks a lot of having loss in contrast on certain color schems with your patch try for instance breezedark and the honeycomb system theme, the current task highlight would probably almost disappear

This is bringing it in line with Breeze Light which already has the color schemes influencing the taskbar color. I tested with honeycomb and it seemed to work fine.

filipf accepted this revision.May 24 2019, 6:50 PM
filipf added a subscriber: filipf.

So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good solution, +1 for the idea.

I gave it a quick spin with Breeze Dark however and it's just not picking up some color schemes. It remains stuck on the colors of some previous scheme that worked. This seems to be random and may be a bug originating elsewhere so I'm hitting accept.

This revision is now accepted and ready to land.May 24 2019, 6:50 PM
In D21378#469517, @mart wrote:

the idea is kinda nice and with some schemes it will work just perfect...
however i think it risks a lot of having loss in contrast on certain color schems with your patch try for instance breezedark and the honeycomb system theme, the current task highlight would probably almost disappear

This is bringing it in line with Breeze Light which already has the color schemes influencing the taskbar color. I tested with honeycomb and it seemed to work fine.

Actually, Breeze Light should have had the same problem as Breeze Dark. It's Breeze that should have already been adapting to the system colorscheme because it didn't have any colors defined.

ndavis added a comment.EditedMay 24 2019, 6:58 PM

So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good solution, +1 for the idea.

I gave it a quick spin with Breeze Dark however and it's just not picking up some color schemes. It remains stuck on the colors of some previous scheme that worked. This seems to be random and may be a bug originating elsewhere so I'm hitting accept.

After changing the system colorscheme, did you try restarting plasmashell or switching to a different desktop theme and switching back? I'll admit, it's a bit janky, but it should work if you do that. It definitely seems like a bug that originates from elsewhere.

So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good solution, +1 for the idea.

I gave it a quick spin with Breeze Dark however and it's just not picking up some color schemes. It remains stuck on the colors of some previous scheme that worked. This seems to be random and may be a bug originating elsewhere so I'm hitting accept.

After changing the system colorscheme, did you try restarting plasmashell or switching to a different desktop theme and switching back? I'll admit, it's a bit janky, but it should work if you do that. It definitely seems like a bug that originates from elsewhere.

Restarting plasmashell yes, switching to a different theme nope. But I did now and that seems to be working.

So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good solution, +1 for the idea.

I gave it a quick spin with Breeze Dark however and it's just not picking up some color schemes. It remains stuck on the colors of some previous scheme that worked. This seems to be random and may be a bug originating elsewhere so I'm hitting accept.

After changing the system colorscheme, did you try restarting plasmashell or switching to a different desktop theme and switching back? I'll admit, it's a bit janky, but it should work if you do that. It definitely seems like a bug that originates from elsewhere.

Restarting plasmashell yes, switching to a different theme nope. But I did now and that seems to be working.

It's very wonky but what worked for me was: change the desktop theme, not the look and feel, then change the color scheme to the one you want and finally change the desktop theme to Breeze Dark

@mart If you're not opposed to this patch, I'll go ahead and land this.

This revision was automatically updated to reflect the committed changes.