[Notifications] Unwatch job when it gets stopped
ClosedPublic

Authored by broulik on May 23 2019, 1:39 PM.

Details

Summary

We watch the service owner so that when it dies without finishing the job we communicate an error to the user.
When the job is stopped, the job is "done" and we don't need to watch the service anymore.

Test Plan
  • Started a copy, finished it, quit Dolphin: no longer got a "job unregistered" message
  • Started a copy, killed Dolphin: got a "application closed unexpectedly" job error
  • Started a copy, finished it, started a second copy, killed Dolphin, still got the error message

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.May 23 2019, 1:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2019, 1:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 23 2019, 1:39 PM
ngraham accepted this revision.May 23 2019, 4:54 PM
This revision is now accepted and ready to land.May 23 2019, 4:54 PM
This revision was automatically updated to reflect the committed changes.