[Notifications] Avoid stale screenRect
ClosedPublic

Authored by broulik on May 23 2019, 12:50 PM.

Details

Summary

AppletInterface does not emit change signals for screen properties, only ContainmentInterface does it.
Since a fix will only be in a future version 5.16 won't depend on, mitigate the effect by not caching the property.
The property was only a lazy Connections replacement anyway.
Also, compress screen change updates to avoid flickery animation of the popup as you resize the panel.

CCBUG: 407504
BUG: 399257

Test Plan

For some reason all of this used to work two weeks ago but I tried going back to an older p-w and p-f to no avail...

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 23 2019, 12:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2019, 12:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 23 2019, 12:50 PM
broulik edited the test plan for this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
apol added a subscriber: apol.May 23 2019, 1:23 PM

Seems like a workaround...

Not really. I previously had the property there because I was too lazy to add a Connections since QObject has no default property and requires this property... boilerplate. The code is valid either way, however, this one actually mostly works with Frameworks 5.58

mart accepted this revision.May 24 2019, 12:37 PM
This revision is now accepted and ready to land.May 24 2019, 12:37 PM
This revision was automatically updated to reflect the committed changes.