Differential D21361

[Notifications] Remove "Notifications" heading
ClosedPublic
Actions

Authored by broulik on May 23 2019, 8:21 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R120:f6f046516530: [Notifications] Remove "Notifications" heading
Summary

It is redundant with the title added by system tray. Even when added standalone it is kind of obvious that this is notifications.
The clear button is moved next to the configure button.

Test Plan

5.16 branch


Clear button is aligned with "configure" button on notifications, hence the spacing: 0
No notifications text still shows up fine

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 23 2019, 8:21 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2019, 8:21 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 23 2019, 8:21 AM
ngraham accepted this revision.May 23 2019, 3:50 PM
ngraham added a subscriber: ngraham.

+1, shipit!

This revision is now accepted and ready to land.May 23 2019, 3:50 PM
Closed by commit R120:f6f046516530: [Notifications] Remove "Notifications" heading (authored by broulik). · Explain WhyMay 24 2019, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58592

View Options

applets/notifications/package/contents/ui/FullRepresentation.qml

Loading...