Differential D21360

[Notifications] Remove action mnemonics from tooltip
ClosedPublic
Actions

Authored by broulik on May 23 2019, 8:10 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R120:70611825b1ea: [Notifications] Remove action mnemonics from tooltip
Summary

Otherwise shows up as ampersand.

BUG: 407853
FIXED-IN: 5.16.0

Test Plan

Code inspired by qtquickcontrols 1 utils

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 23 2019, 8:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2019, 8:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 23 2019, 8:10 AM
ngraham added a subscriber: ngraham.May 23 2019, 3:53 PM

Seems like something that the button should do automatically for us? Or is it not doing that because it would be throwing away all ampersands?

broulik added a comment.May 23 2019, 4:01 PM

The button text handles mnemonics but the/a tooltip doesn't and never did

ngraham accepted this revision.May 23 2019, 4:05 PM

Oh right, gotcha.

This revision is now accepted and ready to land.May 23 2019, 4:05 PM
Closed by commit R120:70611825b1ea: [Notifications] Remove action mnemonics from tooltip (authored by broulik). · Explain WhyMay 24 2019, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58591

View Options

applets/notifications/package/contents/ui/FullRepresentation.qml

Loading...