Differential D21357

User Switcher Plasma applet: Option to not lock screen on switch user session action
Needs ReviewPublic
Actions

Authored by Murz on May 23 2019, 3:43 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

On home computers for family usage users very often switch between family member account sessions, so always entering passwords is very annoying.

This patch add to applet setting new option for not locking screen on switch user action

Test Plan
  1. Open User Switcher Plasma applet settings window, toggle "No lock session on user switch" on.
  1. Try to switch user session and check that current user session is not locked (when switched back to current user session).
  1. Open User Switcher Plasma applet settings window, toggle "No lock session on user switch" off, and check that session locking works again.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Murz created this revision.May 23 2019, 3:43 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2019, 3:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
Murz requested review of this revision.May 23 2019, 3:43 AM
Murz added a reviewer: Plasma.
Murz updated this revision to Diff 58525.May 23 2019, 4:09 AM

Fixed saving configuration value and swap actions

Murz updated this revision to Diff 58527.May 23 2019, 4:20 AM

Add skip locking on New Session action too.

broulik added a subscriber: broulik.May 23 2019, 7:40 AM

It is currently controlled by the "automatically lock screen" option (the shouldLock property) in screen locker settings. I would prefer to have a dedicated setting there which affects every user switching place (e.g. via kickoff and what not) rather than having a specific setting in this applet.

Murz added a comment.EditedMay 23 2019, 11:30 AM

Thanks for pointing this, I wasn't think before, that those options are linked! Will be good to add text description for users in widget settings window, pointing to this. @broulik, if you approve this, I can make new diff.

broulik added a comment.May 24 2019, 10:35 AM

I think having a separate checkbox "[X] Lock when switching users" or something could be handy
VDG what do you think?

ngraham added a subscriber: ngraham.May 24 2019, 1:36 PM
In D21357#469387, @broulik wrote:

I think having a separate checkbox "[X] Lock when switching users" or something could be handy
VDG what do you think?

Yeah I think that seems reasonable enough.

Revision Contents
Changeset List

Diff 58527

View Options

applets/userswitcher/package/contents/config/main.xml

Loading...
View Options

applets/userswitcher/package/contents/ui/configGeneral.qml

Loading...
View Options

applets/userswitcher/package/contents/ui/main.qml

Loading...