Differential D21342

[kcmkwin/touchscreen+screenedges] Call KRunner KRunner
ClosedPublic
Actions

Authored by ngraham on May 22 2019, 2:22 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
KWin
Maniphest Tasks
T10966: Unify how we refer to KRunner
Commits
R108:151659574218: [kcmkwin/touchscreen+screenedges] Call KRunner KRunner
Summary

In the context of the Touch Screen and Screen Edges KCM, using the term "Run Command" to
refer to KWin is inaccurate and misleading. By using a string that starts with an action
verb and no ellipses, it is suggested that the action is literally to run some command,
prompting the user to think "which command will it run? How do I choose what it is?"

This patch changes the action text to "Show KRunner" which is the proposed new standard.

See T10966: Unify how we refer to KRunner for more information and reasons why to do this.

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.May 22 2019, 2:22 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 22 2019, 2:22 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
ngraham requested review of this revision.May 22 2019, 2:22 PM
ngraham edited the test plan for this revision. (Show Details)May 22 2019, 2:22 PM
davidedmundson added a subscriber: davidedmundson.May 22 2019, 2:36 PM

Code wise it's obviously fine and the goal of being consistent definitely makes sense.

Personally I don't like the name chosen, but there's no point discussing that everywhere.
Consider this a ship it that's conditional on D21341 + whatever else getting approved.

ngraham added a comment.May 22 2019, 2:49 PM

Thanks! If you have an idea for a better name, please feel free to bring it up in T10966.

ndavis accepted this revision.May 22 2019, 6:04 PM
ndavis added a subscriber: ndavis.

Makes sense to me. "Run command" is far too vague. The first time I saw it, I thought it would let me run a command or bash script instead of opening KRunner.

This revision is now accepted and ready to land.May 22 2019, 6:04 PM
Closed by commit R108:151659574218: [kcmkwin/touchscreen+screenedges] Call KRunner KRunner (authored by ngraham). · Explain WhyMay 22 2019, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58502

View Options

kcmkwin/kwinscreenedges/main.cpp

Loading...
View Options

kcmkwin/kwinscreenedges/touch.cpp

Loading...