Differential D21335

Don't write a anti-aliasing settings from startkde
ClosedPublic
Actions

Authored by bshah on May 22 2019, 11:29 AM.

Details

Reviewers
ngraham
apol
davidedmundson
Group Reviewers
Plasma
Commits
R120:1af4680ea846: Don't write a anti-aliasing settings from startkde
Summary

Writing a config files in $HOME at start-up is wrong way of setting
defaults, If defaults needs to be set, they should be set by krdb
instead of the startkde.

Another side-effect of writing config file is that this breaks the
distribution/vendor configuration, who might want to configure this
value by shipping kdeglobals in either /etc/xdg or $XDG_CONFIG_DIRS.

BUG: 407754
CCBUG: 389598

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah created this revision.May 22 2019, 11:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 22 2019, 11:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah requested review of this revision.May 22 2019, 11:29 AM
bshah added a comment.May 22 2019, 3:57 PM

This revision have a follow up revisions to plasma-desktop, please wait before reviewing this one.

bshah added a reviewer: Plasma.May 23 2019, 9:11 AM

D21362 is follow-up review to this one.. all 4 patches needs to go together.

apol added a subscriber: apol.May 23 2019, 1:20 PM

Probably needs removing from startplasmacompositor too then.

bshah updated this revision to Diff 58544.May 23 2019, 1:32 PM

remove from startplasmacompositor as well

bshah added a comment.May 23 2019, 1:32 PM
In D21335#469040, @apol wrote:

Probably needs removing from startplasmacompositor too then.

Good call, thanks.

ngraham accepted this revision.May 23 2019, 1:38 PM

Sweet, this will be a great change.

This revision is now accepted and ready to land.May 23 2019, 1:38 PM
apol accepted this revision.May 23 2019, 1:41 PM
davidedmundson accepted this revision.May 27 2019, 7:05 AM
Closed by commit R120:1af4680ea846: Don't write a anti-aliasing settings from startkde (authored by bshah). · Explain WhyMay 27 2019, 9:15 AM
This revision was automatically updated to reflect the committed changes.
bshah mentioned this in R119:873cbc1da8f3: Set defaults for anti-aliasing using the krdb.

Revision Contents
Changeset List

Diff 58715

View Options

startkde/startkde.cmake

Loading...
View Options

startkde/startplasmacompositor.cmake

Loading...