Differential D21320

Fix build with poppler < 0.51
ClosedPublic
Actions

Authored by volkov on May 21 2019, 3:49 PM.

Details

Reviewers
sander
Group Reviewers
Okular
Commits
R223:32786e6b3d8d: Fix build with poppler < 0.51

Diff Detail

Repository
R223 Okular
Branch
Applications/19.04
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12025
Build 12043: arc lint + arc unit
volkov created this revision.May 21 2019, 3:49 PM
Restricted Application added a project: Okular. · View Herald TranscriptMay 21 2019, 3:49 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
volkov requested review of this revision.May 21 2019, 3:49 PM
sander accepted this revision.May 22 2019, 8:37 AM
This revision is now accepted and ready to land.May 22 2019, 8:37 AM
volkov closed this revision.May 22 2019, 12:33 PM
joaonetto added a subscriber: joaonetto.EditedMay 22 2019, 8:14 PM

This broke the compilation process on my machine. I just tested with a clean version of KDE Neon, Poppler 0.62, and it doesn't compile, something about FormFieldsSignatures.

Must also say that after I reverted back the commit, it compiled.

Is this only happening to me?

Edit: Tried with Poppler 0.76.1, still gave me error, error in the pastebin:
https://pastebin.com/aFX4Rb1a

Cmake Log showing Poppler 0.76.1
https://pastebin.com/Wh3nEexT

aacid added a subscriber: aacid.May 22 2019, 8:57 PM

I've reverted the changeset since it was breaking the build

sander added a comment.May 23 2019, 4:42 AM

My error. Apologies!

volkov added a comment.May 23 2019, 10:31 AM

Sorry. I didn't add #include <config-okular-poppler.h> to formfields.h.
Correct fix: D21363.

Revision Contents
Changeset List

Diff 58417

View Options

generators/poppler/formfields.h

Loading...
View Options

generators/poppler/formfields.cpp

Loading...
View Options

generators/poppler/generator_pdf.cpp

Loading...