Optimise the NetworkModel
ClosedPublic

Authored by apol on May 20 2019, 2:35 PM.

Details

Summary

Only notify changes about the bits that actually changed.
This is especially important for sorted lists, as a small change on a detail could trigger a resort and redraw of the whole view, especially at boot.

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.May 20 2019, 2:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 20 2019, 2:35 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.May 20 2019, 2:35 PM
jgrulich accepted this revision.May 20 2019, 6:03 PM

Looks good.

libs/models/networkmodelitem.cpp
561

This will remove the '%' at the end of signal strength.

This revision is now accepted and ready to land.May 20 2019, 6:03 PM
apol marked an inline comment as done.May 20 2019, 11:32 PM
This revision was automatically updated to reflect the committed changes.