Set application name to org_kde_powerdevil
ClosedPublic

Authored by bshah on May 20 2019, 12:29 PM.

Details

Summary

Previously application component name without any KAboutData was
org_kde_powerdevil (executable name), although, 972eb26d0558d commit
changed the component name to powerdevil, which had side-effects that
powerdevil would write shortcuts to powerdevil component and it would
conflict with old org_kde_powerdevil shortcuts, and ultimately none
would work.

In theory we can do migration of the shortcuts to powerdevil component
using kconf_update but that doesn't work, as kglobalaccel is already
started before powerdevil, resulting in kconf_update changes having no
effect, more on this in commit 4ae36ddddae which introduces the
PowerDevilApp::migratePre512KeyboardShortcuts() function, while in
theory PowerDevilApp::migratePre516KeyboardShortcuts can be introduced,
we can simply avoid this hassle by re-assigning old component name.

BUG: 407721

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah created this revision.May 20 2019, 12:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 20 2019, 12:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah requested review of this revision.May 20 2019, 12:29 PM
fvogt added a subscriber: fvogt.May 20 2019, 12:30 PM
davidedmundson accepted this revision.May 20 2019, 12:34 PM

Probably needs a matching
KAboutData::setProductName to "powerdevil"

This revision is now accepted and ready to land.May 20 2019, 12:34 PM
bshah updated this revision to Diff 58355.May 20 2019, 12:41 PM

setProductName

This revision was automatically updated to reflect the committed changes.