[tabbox] Properly determine depressed modifiers on X11
ClosedPublic

Authored by zzag on May 20 2019, 11:52 AM.

Details

Summary

A keysym can be assigned to several keycodes, so more proper way to
determine whether given modifier is depressed is to iterate over all
returned keycodes and see if any is pressed.

If we check only the first keycode, then alternative mappings may not
work, e.g. alt key mapped to win, etc.

BUG: 407720

Diff Detail

Repository
R108 KWin
Branch
tabbox-modifiers
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11979
Build 11997: arc lint + arc unit
zzag created this revision.May 20 2019, 11:52 AM
Restricted Application added a project: KWin. · View Herald TranscriptMay 20 2019, 11:52 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.May 20 2019, 11:52 AM
zzag edited the summary of this revision. (Show Details)May 20 2019, 12:44 PM
zzag updated this revision to Diff 58402.May 21 2019, 11:44 AM
zzag retitled this revision from [tabbox] Use xkb to determine depressed modifiers on X11 to [tabbox] Properly determine depressed modifiers on X11.
zzag edited the summary of this revision. (Show Details)

XInput is not a mandatory dependency. :'(

zzag updated this revision to Diff 58403.May 21 2019, 11:57 AM

prettify

zzag updated this revision to Diff 58404.May 21 2019, 11:58 AM

remove no longer actual comment

davidedmundson accepted this revision.May 21 2019, 12:24 PM
This revision is now accepted and ready to land.May 21 2019, 12:24 PM
This revision was automatically updated to reflect the committed changes.