Observatory module with basic dome and weather handling created
ClosedPublic

Authored by wreissenberger on May 19 2019, 1:25 PM.

Details

Summary

The Observatory module is a new EKOS module for handling all dome and weather devices. This initial implementation creates only basic functionality:

  • Display weather information
  • Park and unpark a dome
  • Open and close a shutter
  • Closing shutter / parking dome for weather status changes
Test Plan

Since everything has been developed with the INDI dome and weather simulators, it is of special importance testing the functionality against real hardware.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.May 19 2019, 1:25 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 19 2019, 1:25 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.May 19 2019, 1:25 PM

D-Bus interface added.

Tool tips added to the Observatory module

Do we create a feature branch for this, or do we use the trunk?

You're right, this is a big change that needs to sit in its own feature branch until it is thoroughly tested. But it's a very good start!

Currently, the interference with with other modules isn't that heavy, so technically it is not necessary. Nevertheless, I would prefer a feature branch so that we can launch the module with a mature set of functionality.

  • Handling disconnects for weather and dome added
  • UI elements for observatory actions and status added - not implemented yet

Taking actions due to weather warnings or alerts implemented

wreissenberger edited the summary of this revision. (Show Details)May 22 2019, 8:13 AM

Execute actions for weather warnings and alerts

Thanks in advance for your answer.

kstars/ekos/observatory/observatory.ui
15

Can it be removed or replaced with some meaningful title?

Observatory windows title set to Observatory

wreissenberger marked an inline comment as done.May 22 2019, 6:53 PM

Et voilà.

kstars/ekos/observatory/observatory.ui
15

Better?

Et voilà.

Thanks.

wreissenberger marked an inline comment as done.

Action check box for stopping the scheduler added (not implemented)

  • Shutter actions invisible if no shutter present
  • Measurement of delay in secs
  • Scheduler actions prepared, but left invisible

Observatory status added

Make observatory ready with one mouse click

From my perspective, we could start now with the feature branch. Currently, the Observatory is standalone. As a next step, I would like to implement the interaction with the Scheduler, but this should be handled in a separate diff.

What do you think?

  • Wolfgang
TallFurryMan accepted this revision.May 26 2019, 8:22 PM

This is neat. Feature branch for the time being indeed.

This revision is now accepted and ready to land.May 26 2019, 8:22 PM

Jasem created the branch "observatory_work" for this activity.

So how does this work? From what I understand, you/me/devs need to make this branch live, breathing changes from master. Adding changes the generic way should be:

  1. Locally, configure and fetch the upstream repository (git fetch origin)
  2. If you don't have a local/observatory_work branch, check upstream/observatory_work out. No conflicts as it is new. (git checkout --track --branch observatory_work)
  3. If you already have a local/observatory_work branch, check it out and pull upstream/observatory_work changes into to. This may cause conflicts that you have to resolve. (git checkout observatory_work ; git pull)
  4. If there were conflicts, you now have a merge commit in local/observatory_work. Make a separate differential out of it to have origin/observatory_work catch up with the changes. (arc diff)
  5. If you are starting a new development activity, branch local/observatory_work into your work branch. (git checkout --track --branch activity__my_subject)
  6. If you are rebasing an existing activity, check it out and rebase local/activitymy_subject onto the changes that were pulled into local/observatory_work. (git checkout activitymy_subject ; git pull --rebase)
  7. Make a differential out of your changes. (arc diff or explicit arc diff --update <Dxx>)
  8. Rinse and repeat as the repository breathes.

Note my checklist makes use of branch tracking to simplify the commands and document how the activities are linked. Changes potentially source from upstream/master, upstream/observatory_work and your local/observatory_work.

TallFurryMan requested changes to this revision.May 29 2019, 6:25 AM

So please rebase your changes and eventually issue a preliminary differential to make observatory_work live.

This revision now requires changes to proceed.May 29 2019, 6:25 AM

Switched to branch observatory_work

Ready-button deactivated, showing only the status

Checkboxes for weather status actions implemented

TallFurryMan accepted this revision.Jun 3 2019, 6:09 AM

Sorry for the delay.

This revision is now accepted and ready to land.Jun 3 2019, 6:09 AM

Many thanks, so let's start the feature branch. As a next step I would like to discuss with you the interaction of Observatory and Scheduler.

But I think it's better doing this on a new diff.

  • Wolfgang
mutlaqja accepted this revision.Jun 11 2019, 8:10 AM
This revision was automatically updated to reflect the committed changes.