Linux has /proc so it doesn't matter there, but e.g. on FreeBSD
lying about argc[0] leads to applicationDirPath() being wrong,
which leads to the kioslave executable not being found in CI
(because it's looking in applicationDirPath(), which for a kioslave
was build/bin/kf5/kio, where e.g. trash.so can be found)
Details
Details
commenting out the Q_OS_LINUX block in qcoreapplication.cpp,
uninstalling kio, then running bin/dropjobtest shouldDropFromTrash.
Failed with "kioslave not found", works after this fix.
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- 2019_freebsd_fixed
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11945 Build 11963: arc lint + arc unit
| src/kioslave/kioslave.cpp | ||
|---|---|---|
| 132 | Now has a leak, use vector instead. | |
Comment Actions
Just out of curiosity: Does one need the exit(func(...)) call or wouldn't a return func...(); be enough?
Comment Actions
Good question. It seems to me that return would indeed be much better so that the stack gets unwinded... I'll make the change.