Scrap Public Key Cryptography code based on QCA as QDbus is secure enough
ClosedPublic
Actions

Authored by shubham on May 18 2019, 6:52 PM.

Details

Reviewers

stikonas
cjlcarvalho

Commits

R16:a7532d4041de: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough

Summary

QDbus already provides enough security to the calls made by the application to the helper. Hence no need to encrypt, sign the requests of the application and verify their integrity at the helper side.

Diff Detail

Repository

R16 KPMCore

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

shubham requested review of this revision.May 18 2019, 6:52 PM

shubham created this revision.

Harbormaster completed remote builds in B11929: Diff 58262.May 18 2019, 6:52 PM

shubham added a reviewer: cjlcarvalho.May 18 2019, 6:53 PM

shubham added a project: KDE Partition Manager.

shubham added a subscriber: KDE Partition Manager.

Do not remove qca-qt5 from CMakeLists.txt

Harbormaster completed remote builds in B11953: Diff 58306.May 19 2019, 2:38 PM

stikonas accepted this revision.May 19 2019, 5:22 PM

This revision is now accepted and ready to land.May 19 2019, 5:22 PM

Closed by commit R16:a7532d4041de: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough (authored by shubham). · Explain WhyMay 19 2019, 5:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/util/externalcommand.h (10 lines)
M			src/util/externalcommand.cpp (116 lines)
M			src/util/externalcommandhelper.h (19 lines)
M			src/util/externalcommandhelper.cpp (120 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58262	07b2ce3		May 18 2019, 6:52 PM	★	★
Diff 2	58306	07b2ce3	Do not remove qca-qt5 from CMakeLists.txt	May 19 2019, 2:38 PM	★	★
Diff 3	58312	6f8e640	R16:a7532d4041de7de6c7df7fbe1fb7fd0a50fcab96	May 19 2019, 5:23 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
36e111cea804	d4d08b8c3279	07b2ce305412	Shubham Jangra	Scrap Public Key Cryptography code based on QCA as QDbus is secure enough (Show More…)	May 18 2019, 6:50 PM