[Touchpad KCM] Fixed loading of wrong qml file
ClosedPublic

Authored by atulbi on May 18 2019, 10:58 AM.

Details

Summary

On system settings, If Mouse KCM is opened first, then touchpad KCM loads the same Mouse QML file (qrc:/libinput/main.qml) instead of Touchpad Qml file.
Having same url (qrc:/libinput/main.qml).

Fix: simply renaming qml files fixed the issue.There could be better solutions though.

Also removed unused configProps from D21228.

BUG: 398228

Test Plan
  1. Renamed main.qml to touchpad.qml .
  2. Edited resource file to reflect change.
  3. When compiled with these changes and opened touchpad setting, it was all blank, which was expected (because i did not changed the source).But opening mouse and then

touchpad shows mouse settigs. So it Confirmed the cause.

  1. Now changing source and compiling it fixes the issue. Now, no more mouse on Touchpad and vice-versa.

Diff Detail

Repository
R119 Plasma Desktop
Branch
touchpad-mouse
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11918
Build 11936: arc lint + arc unit
atulbi created this revision.May 18 2019, 10:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 18 2019, 10:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
atulbi requested review of this revision.May 18 2019, 10:58 AM
atulbi edited the summary of this revision. (Show Details)May 18 2019, 11:08 AM
atulbi added reviewers: romangg, ngraham.
atulbi edited the summary of this revision. (Show Details)May 18 2019, 11:12 AM
romangg accepted this revision.May 18 2019, 1:30 PM

Good find. Also backport to beta branch.

This revision is now accepted and ready to land.May 18 2019, 1:30 PM
This revision was automatically updated to reflect the committed changes.