Differential D21258

Move slot under Q_SLOTS
AbandonedPublic
Actions

Authored by shubham on May 17 2019, 4:52 PM.

Details

Reviewers
stikonas
cjlcarvalho
Summary

This is actually a slot declared under public functions

Diff Detail

Repository
R16 KPMCore
Branch
slot
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11898
Build 11916: arc lint + arc unit
shubham requested review of this revision.May 17 2019, 4:52 PM
shubham created this revision.
stikonas added a comment.May 17 2019, 4:54 PM

We also don't need this. Q_SLOTS are needed with old style Qt syntax where SIGNAL and SLOTS are used. With the new Qt5 connect syntax, you can just connect to any function, so no need to involve moc on this function.

stikonas requested changes to this revision.May 17 2019, 4:55 PM
This revision now requires changes to proceed.May 17 2019, 4:55 PM
shubham abandoned this revision.May 17 2019, 4:57 PM

Revision Contents
Changeset List

PathPackages
Msrc/util/externalcommand.h (3 lines)

Diff 58205

View Options

src/util/externalcommand.h

Loading...