Differential D21253

Enable and disable UI controls properly based on sharing status
ClosedPublic
Actions

Authored by ngraham on May 17 2019, 3:47 PM.

Details

Reviewers
filipf
Group Reviewers
VDG
Commits
R432:ef5881c34ace: Merge branch 'Applications/19.04'
R432:29c9fc1d09b9: Enable and disable UI controls properly based on sharing status
Summary

When a folder isn't shared, all of the UI controls that depend on it being shared
should be disabled.

BUG: 407500
FIXED-IN: 19.04.1

Test Plan

Diff Detail

Repository
R432 File Sharing (Samba) integration
Branch
enable-and-disable-controls-properly (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11896
Build 11914: arc lint + arc unit
ngraham requested review of this revision.May 17 2019, 3:47 PM
ngraham created this revision.
ngraham edited the test plan for this revision. (Show Details)May 17 2019, 3:48 PM
filipf accepted this revision.May 17 2019, 6:28 PM
This revision is now accepted and ready to land.May 17 2019, 6:28 PM
Closed by commit R432:29c9fc1d09b9: Enable and disable UI controls properly based on sharing status (authored by ngraham). · Explain WhyMay 17 2019, 8:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 58198

View Options

samba/filepropertiesplugin/sambausershareplugin.cpp

Loading...
View Options

samba/filepropertiesplugin/sambausershareplugin.ui

Loading...