Remove redundant include
ClosedPublic

Authored by shubham on May 17 2019, 3:32 PM.

Diff Detail

Repository
R16 KPMCore
Branch
include
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11897
Build 11915: arc lint + arc unit
shubham requested review of this revision.May 17 2019, 3:32 PM
shubham created this revision.
shubham updated this revision to Diff 58199.May 17 2019, 3:57 PM

More redundant include

stikonas requested changes to this revision.May 17 2019, 4:45 PM

It is needed by std::unique_ptr and std::unordered_set. We shouldn't rely on header being pulled in by some other header.

This revision now requires changes to proceed.May 17 2019, 4:45 PM

The other include (#include "externalcommandhelper.h") I think can still go away but please test that it builds in a clean build dir.

shubham updated this revision to Diff 58209.May 17 2019, 5:01 PM

Do not remove <memory>

please test that it builds in a clean build dir.

I do not know what do you mean? tests?

please test that it builds in a clean build dir.

I do not know what do you mean? tests?

well, just do compilation in a folder that wasn't used before. How do you build kpmcore?

E.g. I do mkdir build; cd build; cmake ..; make

So by clean build dir, I mean remove build dir before running mkdir build; cd build; cmake ..; make

stikonas accepted this revision.May 17 2019, 5:04 PM
This revision is now accepted and ready to land.May 17 2019, 5:04 PM
shubham added a comment.EditedMay 17 2019, 5:05 PM

Oh, I do by running kdesrc-build script, which takes care of removing old build directory.
Please push this and the other revision on my behalf : )

oh ok, that's fine then.

stikonas added a comment.EditedMay 17 2019, 5:06 PM

Oh, I do by running kdesrc-build script, which takes care of removing old build directory.
Please push this and the other revision on my behalf : )

Don't you have commit access yet? I thought you have. If not I can merge if you open merge request on invent.kde.org

I have commit access, but It says access denied. Remember you had said it is hosted on remote server.

I have commit access, but It says access denied. Remember you had said it is hosted on remote server.

You have access to it too. Just push URL is different (git@invent.kde.org:kde/kpmcore.git)

Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks

Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks

You need to update URL of origin (which was set the first time you (or kdesrc-build) cloned). Well, you can use text editor to edit .git/config file and fix URL there.

This revision was automatically updated to reflect the committed changes.