Differential D21245

KAr::openArchive: Also check ar_longnamesIndex is not < 0
ClosedPublic
Actions

Authored by aacid on May 16 2019, 8:23 PM.

Details

Reviewers
adridg
Commits
R243:98470cd72bc6: KAr::openArchive: Also check ar_longnamesIndex is not < 0

Diff Detail

Repository
R243 KArchive
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11885
Build 11903: arc lint + arc unit
aacid created this revision.May 16 2019, 8:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 16 2019, 8:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.May 16 2019, 8:23 PM
adridg accepted this revision.May 16 2019, 8:27 PM
adridg added a subscriber: adridg.

ar_longnamesIndex is used as an array-index into ar_longnames, which is new[]ed, so a negative index is UB. This patch voids that case.

This revision is now accepted and ready to land.May 16 2019, 8:27 PM
aacid closed this revision.May 16 2019, 8:28 PM

Revision Contents
Changeset List

PathPackages
Msrc/kar.cpp (2 lines)

Diff 58175

View Options

src/kar.cpp

Loading...