Simplify test conditions
ClosedPublic

Authored by shubham on May 16 2019, 7:15 PM.

Diff Detail

Repository
R16 KPMCore
Branch
simplify
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11883
Build 11901: arc lint + arc unit
shubham requested review of this revision.May 16 2019, 7:15 PM
shubham created this revision.
shubham added a project: KDE Partition Manager.
shubham added a subscriber: KDE Partition Manager.
shubham added inline comments.
src/util/externalcommandhelper.cpp
50

This return QDbusError::Disconnect in case of failure. So why not use the message() function instead of printing.

stikonas accepted this revision.May 16 2019, 7:23 PM
stikonas added inline comments.
src/util/externalcommandhelper.cpp
50

No particular reason, I think just copied it from somewhere, feel free to change

This revision is now accepted and ready to land.May 16 2019, 7:23 PM
shubham updated this revision to Diff 58173.EditedMay 16 2019, 7:36 PM

Take few more instances into account.
Please push it on my behalf.

This revision was automatically updated to reflect the committed changes.