Use view background color for sidebar to match other sidebars
ClosedPublic

Authored by ngraham on May 15 2019, 4:12 PM.

Details

Summary

Generally, left sidebars in Kirigami-style apps (e.g. System Settings) use the view
background color. Let's do the same in Discover when it's displaying the Desktop view.

Need to bump the Kirigami version to have access to Theme.colorSet

Test Plan

Sidebar is now a pleasing off-white, same as System Settings

Diff Detail

Repository
R134 Discover Software Store
Branch
view-bg-color-for-sidebars (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11862
Build 11880: arc lint + arc unit
ngraham created this revision.May 15 2019, 4:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 15 2019, 4:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 15 2019, 4:12 PM
ngraham edited the summary of this revision. (Show Details)May 15 2019, 4:14 PM
ngraham edited the summary of this revision. (Show Details)
ngraham updated this revision to Diff 58135.May 15 2019, 4:19 PM

Only for desktop view

ngraham edited the summary of this revision. (Show Details)May 15 2019, 4:20 PM
apol accepted this revision.May 15 2019, 4:21 PM
This revision is now accepted and ready to land.May 15 2019, 4:21 PM
This revision was automatically updated to reflect the committed changes.
filipf added a subscriber: filipf.May 15 2019, 4:31 PM

You were too quick for me but just wanted to say: nice!

I also saw that we needed to fix the color errors in the System Settings sidebar and you solved that as well :)